Windows: add guards for some methods that don't work/exist on windows#295
Merged
GDYendell merged 3 commits intoDiamondLightSource:mainfrom Jan 12, 2026
Conversation
Tom-Willemsen
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 90.82% 90.67% -0.15%
==========================================
Files 70 70
Lines 2486 2532 +46
==========================================
+ Hits 2258 2296 +38
- Misses 228 236 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
reviewed
Dec 19, 2025
Exception was also occuring in other non-console contexts, e.g. sphinx
Tom-Willemsen
force-pushed
the
guard_methods_that_dont_work_on_windows
branch
from
e4c48ae to
ce40c51
Compare
GDYendell
requested changes
Jan 9, 2026
Contributor
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
This looks good. Just a couple of minor changes.
GDYendell
approved these changes
Jan 12, 2026
Contributor
|
Thanks @Tom-Willemsen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some minimal changes to allow a FastCS driver to start on Windows.
loop.add_signal_handler()is not available on windows. On windows, signals are always delivered to the main thread of an application. Ctrl-c does correctly stop a FastCS driver in non-interactive mode on windows without this handler.StdoutProxydidn't work on windows under pytest - I believe it is conflicting with pytest's stdout capturing. Just usesys.stdoutfor that case.FastCS' own unit tests don't pass on Windows even with this change - that would require a larger PR.